[libc-commits] [PATCH] D136489: [libc.search] [PATCH 3/6] add `search.h` specifications

Schrodinger ZHU Yifan via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Dec 18 11:47:32 PST 2022


SchrodingerZhu added a subscriber: sivachandra.
SchrodingerZhu added a comment.

@sivachandra

Hi,

I have two more questions regarding this:

- `typedef enum { FIND, ENTER } ACTION;` What should I do with a type-defined enum. I mean, should I trait it as a type or an enum (which seems to be distinguished in the header name such as `enum_action.h` and `action.h`)? Same question also applies to the situation of `struct_action` vs `action`.
- Should I ping the reviewers at each patch of the stacked series?

Best,
Yifan


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136489/new/

https://reviews.llvm.org/D136489



More information about the libc-commits mailing list