[libc-commits] [PATCH] D139939: [libc] Make string functions buildable with GCC

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/string/memory_utils/bcmp_implementations.h:103
     return generic::Bcmp<8>::head_tail(p1, p2, count);
-  if constexpr (x86::kAvx512BW)
-    return inline_bcmp_x86_avx512bw_gt16(p1, p2, count);
----------------
What was the problem with these constexpr conditionals? Because the `inline_*` functions are now potentially excluded by the preprocessor, they could be invisible at compile time?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139939/new/

https://reviews.llvm.org/D139939