[libc-commits] [PATCH] D139839: [libc] Add a loader utility for AMDHSA architectures for testing

[Matt Arsenault via Phabricator via libc-commits]

arsenm added inline comments.


================
Comment at: libc/utils/DeviceLoader/amdgpu/CMakeLists.txt:37
+  -nostdinc
+  -mcpu=${AMDGPU_ARCH}
+)
----------------
jhuber6 wrote:
> JonChesterfield wrote:
> > I think this needs to be emit-llvm for amdgpu
> `-c` emits bitcode for `amdgcn-amd-amdhsa` since we consider that the relocatable object type.
-emit-llvm is probably more future proof


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139839/new/

https://reviews.llvm.org/D139839