[libc-commits] [PATCH] D139846: [libc][math] Implement log10 function correctly rounded for all rounding modes

Wed Dec 14 01:02:42 PST 2022

zimmermann6 accepted this revision.
zimmermann6 added a comment.
This revision is now accepted and ready to land.

I tried on 2096978 hard-to-round cases I have generated and all tests pass, with all four rounding modes. Great work!

  zimmerma at biscotte:/tmp/core-math$ LIBM=/localdisk/zimmerma/llvm-project/build/projects/libc/lib/libllvmlibc.a ./check.sh --worst log10
  Running worst cases check in --rndn mode...
  2096978 tests passed, 0 failure(s)
  Running worst cases check in --rndz mode...
  2096978 tests passed, 0 failure(s)
  Running worst cases check in --rndu mode...
  2096978 tests passed, 0 failure(s)
  Running worst cases check in --rndd mode...
  2096978 tests passed, 0 failure(s)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139846/new/

https://reviews.llvm.org/D139846