[libc-commits] [PATCH] D139839: [libc] Add a loader utility for AMDHSA architectures for testing

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Dec 13 22:06:35 PST 2022


sivachandra added a comment.

In D139839#3993691 <https://reviews.llvm.org/D139839#3993691>, @jdoerfert wrote:

> Trying to rephrase (and shorten) what @sivachandra said in the last comment (https://reviews.llvm.org/D139839#3993369):
> "As long as libc does not depend on outside code, we are fine."

Yes, but something more: even the test binary should not depend on code outside of the libc directory. The loader, which takes this binary and loads it on to the device and executes it, can be anywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139839/new/

https://reviews.llvm.org/D139839



More information about the libc-commits mailing list