[libc-commits] [PATCH] D139839: [libc] Add a loader utility for AMDHSA architectures for testing

[Shilei Tian via Phabricator via libc-commits]

tianshilei1992 added a comment.

First of all, I agree with @jdoerfert that it's not a good practice to have a target dependent "loader" (basically almost target dependent duplicate code), given the fact that we (LLVM) already provides a target independent layer, OpenMP. In addition, `libc` would not be the only project in LLVM depending on another project, but of course the `libc` community needs to approve it first. However, I can also understand the concern of bring OpenMP as a dependence for testing (or even feature development), especially OpenMP itself is also a fast evolving project. It's gonna be quite annoying for `libc` community to see some false negative test results because of something off in OpenMP.

I'm thinking one potential solution is to enable `libc` tests in OpenMP test (Buildbot) as well. In this way, OpenMP can make sure that patches will at least not break `libc`, as long as they are not committed directly w/o code review (that's gonna be another story).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139839/new/

https://reviews.llvm.org/D139839