[libc-commits] [PATCH] D139839: [libc] Add a loader utility for AMDHSA architectures for testing

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D139839#3993320 <https://reviews.llvm.org/D139839#3993320>, @jdoerfert wrote:

> In D139839#3993272 <https://reviews.llvm.org/D139839#3993272>, @sivachandra wrote:
>
>> On the general topic of adding dependencies on other projects like `openmp`, we should strive to keep the libc project as self-contained as possible.
>
> The problem is that now we duplicate (and in the future extend) the "gpu launch" logic for each target.
> We are effectively creating yet another offloading runtime. We will invent new abstraction layers, new features will be added, etc.

Let me clarify my side: when I say we should strive to keep the libc project self-contained, I mean that the libc business logic and test logic should be self-contained.  If you can build a test binary using source code only from the `libc` directory, that is good enough. The tests and business logic can use compiler intrinsics. I will let the GPU experts here decide the how/where/what with the test binary and the loaders which load and run the test binary on the device.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139839/new/

https://reviews.llvm.org/D139839