[libc-commits] [PATCH] D139576: [libc] move errno out of file internals

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Dec 12 13:05:11 PST 2022


sivachandra accepted this revision.
sivachandra added inline comments.


================
Comment at: libc/src/__support/CPP/expected.h:21
+  constexpr explicit unexpected(T value) : value(value) {}
+  constexpr T get_value() { return value; }
+};
----------------
The getter should be named `error` according to this: https://en.cppreference.com/w/cpp/utility/expected/unexpected


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139576/new/

https://reviews.llvm.org/D139576



More information about the libc-commits mailing list