[libc-commits] [PATCH] D136799: [libc] Implement a high-precision floating point class.

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

LGTM with minor nits



================
Comment at: libc/src/__support/FPUtil/dyadic_float.h:13
+#include "FPBits.h"
+#include "multiply_add.h"
+#include "src/__support/CPP/type_traits.h"
----------------
I think `dyadic_float.h` should include `float_properties.h` directly.


================
Comment at: libc/src/__support/UInt.h:368-369
 #endif                           // __SIZEOF_INT128__
+    if (unlikely(s == 0))
+      return;
+
----------------
shouldn't this be above the `ifdef __SIZEOF_INT128__`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136799/new/

https://reviews.llvm.org/D136799