[libc-commits] [PATCH] D139576: [libc] move errno out of file internals

[Michael Jones via Phabricator via libc-commits]

michaelrj updated this revision to Diff 482184.
michaelrj marked 5 inline comments as done.
michaelrj added a comment.

address comments:

Moved flush and close to returning an int.
Avoided using additional variables where it was unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139576/new/

https://reviews.llvm.org/D139576

Files:
  libc/src/__support/CMakeLists.txt
  libc/src/__support/CPP/CMakeLists.txt
  libc/src/__support/CPP/error.h
  libc/src/__support/CPP/expected.h
  libc/src/__support/File/CMakeLists.txt
  libc/src/__support/File/file.cpp
  libc/src/__support/File/file.h
  libc/src/__support/File/linux_file.cpp
  libc/src/__support/error_or.h
  libc/src/__support/threads/linux/CMakeLists.txt
  libc/src/__support/threads/linux/thread.cpp
  libc/src/pthread/pthread_setname_np.cpp
  libc/src/stdio/CMakeLists.txt
  libc/src/stdio/fclose.cpp
  libc/src/stdio/fflush.cpp
  libc/src/stdio/fgetc.cpp
  libc/src/stdio/fgetc_unlocked.cpp
  libc/src/stdio/fgets.cpp
  libc/src/stdio/fopen.cpp
  libc/src/stdio/fopencookie.cpp
  libc/src/stdio/fputc.cpp
  libc/src/stdio/fputs.cpp
  libc/src/stdio/fread.cpp
  libc/src/stdio/fread_unlocked.cpp
  libc/src/stdio/fseek.cpp
  libc/src/stdio/ftell.cpp
  libc/src/stdio/fwrite.cpp
  libc/src/stdio/fwrite_unlocked.cpp
  libc/src/stdio/getc.cpp
  libc/src/stdio/getc_unlocked.cpp
  libc/src/stdio/printf_core/file_writer.cpp
  libc/src/stdio/putc.cpp
  libc/src/stdio/putchar.cpp
  libc/src/stdio/puts.cpp
  libc/src/stdio/scanf_core/file_reader.cpp
  libc/test/src/__support/File/file_test.cpp
  libc/test/src/__support/File/platform_file_test.cpp
  libc/test/src/stdio/fileop_test.cpp
  libc/test/src/stdio/ftell_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139576.482184.patch
Type: text/x-patch
Size: 68654 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221212/ae7614bf/attachment-0001.bin>