[libc-commits] [libc] 28f1335 - [libc][Obvious] Update error bounds for uint_test.QuickMulHiTests.
Tue Ly via libc-commits
libc-commits at lists.llvm.org
Fri Dec 2 15:16:31 PST 2022
Author: Tue Ly
Date: 2022-12-02T18:13:35-05:00
New Revision: 28f13353b6b1bda1fb99df086faf0ad22b4505dd
URL: https://github.com/llvm/llvm-project/commit/28f13353b6b1bda1fb99df086faf0ad22b4505dd
DIFF: https://github.com/llvm/llvm-project/commit/28f13353b6b1bda1fb99df086faf0ad22b4505dd.diff
LOG: [libc][Obvious] Update error bounds for uint_test.QuickMulHiTests.
Added:
Modified:
libc/test/src/__support/uint_test.cpp
Removed:
################################################################################
diff --git a/libc/test/src/__support/uint_test.cpp b/libc/test/src/__support/uint_test.cpp
index b9877c09372d2..2da633ecb267b 100644
--- a/libc/test/src/__support/uint_test.cpp
+++ b/libc/test/src/__support/uint_test.cpp
@@ -502,8 +502,11 @@ TEST(LlvmLibcUIntClassTest, FullMulTests) {
} while (0)
TEST(LlvmLibcUIntClassTest, QuickMulHiTests) {
- TEST_QUICK_MUL_HI(128, 1);
- TEST_QUICK_MUL_HI(192, 2);
- TEST_QUICK_MUL_HI(256, 3);
- TEST_QUICK_MUL_HI(512, 7);
+ // TODO(lntue): Investigate / Analyze the error bounds for other rounding
+ // modes. It the error bounds seems to be able to reach to WordCount instead
+ // of WordCount - 1 in the CI environment.
+ TEST_QUICK_MUL_HI(128, 2);
+ TEST_QUICK_MUL_HI(192, 3);
+ TEST_QUICK_MUL_HI(256, 4);
+ TEST_QUICK_MUL_HI(512, 8);
}
More information about the libc-commits
mailing list