[libc-commits] [PATCH] D132825: [libc] Add arm-32 syscall implementation.

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 31 10:54:16 PDT 2022


michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with one nit



================
Comment at: libc/src/__support/OSUtil/linux/arm/syscall.h:24
+  register long r0 __asm__("r0") = arg1;
+#define REGISTER_DECL_2 REGISTER_DECL_1 register long r1 __asm__("r1") = arg2;
+#define REGISTER_DECL_3                                                        \
----------------
nit: should this be formatted like the rest?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132825/new/

https://reviews.llvm.org/D132825



More information about the libc-commits mailing list