[libc-commits] [PATCH] D131994: [libc] move printf to use StringViews

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

A comment about inconsistent usage of a pattern but good to go otherwise.



================
Comment at: libc/test/src/stdio/printf_core/string_writer_test.cpp:36
+      get_writer(reinterpret_cast<void *>(&str_writer));
+  writer.write(string_view("abc", 3));
 
----------------
Can we follow the pattern of `{"abc", 3}` here and elsewhere in the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131994/new/

https://reviews.llvm.org/D131994