[libc-commits] [PATCH] D132254: [libc] Add a span facility

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Aug 19 13:50:53 PDT 2022


sivachandra added inline comments.


================
Comment at: libc/src/__support/CPP/span.h:82
+private:
+  constexpr size_type count_to_size(size_type offset, size_type count) const {
+    if (count == dynamic_extent) {
----------------
gchatelet wrote:
> tschuett wrote:
> > Nit: snake case?
> > Nit:snake case?
> 
> Did you meant camelCase for `dynamic_extent`?
I think `s/countToSize/count_to_size/` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132254/new/

https://reviews.llvm.org/D132254



More information about the libc-commits mailing list