[libc-commits] [PATCH] D132254: [libc] Add a span facility

[Thorsten via Phabricator via libc-commits]

tschuett added inline comments.


================
Comment at: libc/src/__support/CPP/span.h:17
+namespace __llvm_libc {
+namespace cpp {
+
----------------
Nit: You may use nested namespaces.


================
Comment at: libc/src/__support/CPP/span.h:82
+private:
+  constexpr size_type count_to_size(size_type offset, size_type count) const {
+    if (count == dynamic_extent) {
----------------
Nit: snake case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132254/new/

https://reviews.llvm.org/D132254