[libc-commits] [PATCH] D131994: [libc] move printf to use StringViews

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Aug 16 14:05:36 PDT 2022


michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

The FormatSection and the writer functions both previously took a char*
and a length to represent a string. Now they use the StringView class to
represent that more succinctly. This change also required fixing
everywhere these were used, so it touches a lot of files.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131994

Files:
  libc/src/stdio/printf_core/CMakeLists.txt
  libc/src/stdio/printf_core/char_converter.h
  libc/src/stdio/printf_core/converter.cpp
  libc/src/stdio/printf_core/core_structs.h
  libc/src/stdio/printf_core/file_writer.cpp
  libc/src/stdio/printf_core/file_writer.h
  libc/src/stdio/printf_core/float_hex_converter.h
  libc/src/stdio/printf_core/float_inf_nan_converter.h
  libc/src/stdio/printf_core/int_converter.h
  libc/src/stdio/printf_core/parser.cpp
  libc/src/stdio/printf_core/parser.h
  libc/src/stdio/printf_core/printf_main.cpp
  libc/src/stdio/printf_core/ptr_converter.h
  libc/src/stdio/printf_core/string_converter.h
  libc/src/stdio/printf_core/string_writer.cpp
  libc/src/stdio/printf_core/string_writer.h
  libc/src/stdio/printf_core/vfprintf_internal.cpp
  libc/src/stdio/printf_core/writer.cpp
  libc/src/stdio/printf_core/writer.h
  libc/src/stdio/snprintf.cpp
  libc/src/stdio/sprintf.cpp
  libc/test/src/stdio/printf_core/CMakeLists.txt
  libc/test/src/stdio/printf_core/converter_test.cpp
  libc/test/src/stdio/printf_core/parser_test.cpp
  libc/test/src/stdio/printf_core/string_writer_test.cpp
  libc/utils/UnitTest/CMakeLists.txt
  libc/utils/UnitTest/PrintfMatcher.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131994.453124.patch
Type: text/x-patch
Size: 50568 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220816/f09625e0/attachment-0001.bin>


More information about the libc-commits mailing list