[libc-commits] [PATCH] D131752: [libc] Pack memory functions in the integration test libc.a files.

[Michael Jones via Phabricator via libc-commits]

michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with grammar nits



================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:437
+  # We don't want memory functions to be dependencies on integration tests.
+  # For, memory functions should be tested using unittests. The main reason
+  # however is that compiler codegen can emit calls to memory functions. So,
----------------
Nit: delete "For, "


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:439
+  # however is that compiler codegen can emit calls to memory functions. So,
+  # we add them explicitly to the integration test libc.a (see below). Adding,
+  # explicit deps on the memory functions can potentially cause duplicate
----------------
Nit: delete the comma


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131752/new/

https://reviews.llvm.org/D131752