[libc-commits] [PATCH] D131725: [libc] move int conversion out of base template

[Michael Jones via Phabricator via libc-commits]

michaelrj marked an inline comment as done.
michaelrj added inline comments.


================
Comment at: libc/src/__support/integer_to_string.h:115
-    // If This function can actually be a constexpr, then the below "if" will be
-    // optimized out.
     if (buffer.size() < bufsize())
----------------
sivachandra wrote:
> Will be interesting to see if this `if` is being optimized out because `buffer` is a constexpr in your use case.
Yes at high enough optimization settings, along with everything else in this file except the main loop of `convert_alpha_numeric` and a couple other checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131725/new/

https://reviews.llvm.org/D131725