[libc-commits] [PATCH] D131302: [libc] move to combined integer converter

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 10 12:14:22 PDT 2022


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/stdio/printf_core/int_converter.h:73
+  auto str = num_to_strview(num, bufref, to_conv.conv_name);
+  if (!str.has_value())
+    return INT_CONVERSION_ERROR;
----------------
Nit: just do `if (!str)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131302/new/

https://reviews.llvm.org/D131302



More information about the libc-commits mailing list