[libc-commits] [PATCH] D131301: [libc] add int to string for extended bases

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Aug 9 22:51:12 PDT 2022


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/__support/integer_to_string.h:104
+  // on the base or not, depending on if size or performance is required.
+  template <uint8_t STATIC_BASE = BASE,
+            cpp::enable_if_t<2 <= STATIC_BASE && STATIC_BASE <= 36, int> = 0>
----------------
Looks like there is no use for a different `STATIC_BASE`. Can we just remove it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131301/new/

https://reviews.llvm.org/D131301



More information about the libc-commits mailing list