[libc-commits] [libc] 80652d2 - [libc][NFC] Fix a few compiler warnings.

Siva Chandra Reddy via libc-commits libc-commits at lists.llvm.org
Tue Aug 9 15:31:18 PDT 2022


Author: Siva Chandra Reddy
Date: 2022-08-09T22:30:40Z
New Revision: 80652d270aa56bd1072c9967d1e01cbbcb02df70

URL: https://github.com/llvm/llvm-project/commit/80652d270aa56bd1072c9967d1e01cbbcb02df70
DIFF: https://github.com/llvm/llvm-project/commit/80652d270aa56bd1072c9967d1e01cbbcb02df70.diff

LOG: [libc][NFC] Fix a few compiler warnings.

Added: 
    

Modified: 
    libc/src/string/memory_utils/elements_aarch64.h
    libc/utils/LibcTableGenUtil/APIIndexer.cpp

Removed: 
    


################################################################################
diff  --git a/libc/src/string/memory_utils/elements_aarch64.h b/libc/src/string/memory_utils/elements_aarch64.h
index 90b450fc98a2e..394951bae3aaf 100644
--- a/libc/src/string/memory_utils/elements_aarch64.h
+++ b/libc/src/string/memory_utils/elements_aarch64.h
@@ -54,7 +54,7 @@ using _64 = Chained<_32, _32>;
 
 struct ZVA {
   static constexpr size_t SIZE = 64;
-  static void splat_set(char *dst, const unsigned char value) {
+  static void splat_set(char *dst, const unsigned char) {
 #if __SIZEOF_POINTER__ == 4
     asm("dc zva, %w[dst]" : : [dst] "r"(dst) : "memory");
 #else

diff  --git a/libc/utils/LibcTableGenUtil/APIIndexer.cpp b/libc/utils/LibcTableGenUtil/APIIndexer.cpp
index 2630797517f77..deb82a4f95e96 100644
--- a/libc/utils/LibcTableGenUtil/APIIndexer.cpp
+++ b/libc/utils/LibcTableGenUtil/APIIndexer.cpp
@@ -83,7 +83,7 @@ void APIIndexer::indexStandardSpecDef(llvm::Record *StandardSpec) {
   auto HeaderSpecList = StandardSpec->getValueAsListOfDefs("Headers");
   for (llvm::Record *HeaderSpec : HeaderSpecList) {
     llvm::StringRef Header = HeaderSpec->getValueAsString("Name");
-    if (!StdHeader.hasValue() || Header == StdHeader) {
+    if (!StdHeader.has_value() || Header == StdHeader) {
       PublicHeaders.emplace(Header);
       auto MacroSpecList = HeaderSpec->getValueAsListOfDefs("Macros");
       // TODO: Trigger a fatal error on duplicate specs.
@@ -163,7 +163,7 @@ void APIIndexer::index(llvm::RecordKeeper &Records) {
     if (isaStandardSpec(Def))
       indexStandardSpecDef(Def);
     if (isaPublicAPI(Def)) {
-      if (!StdHeader.hasValue() ||
+      if (!StdHeader.has_value() ||
           Def->getValueAsString("HeaderName") == StdHeader)
         indexPublicAPIDef(Def);
     }


        


More information about the libc-commits mailing list