[libc-commits] [PATCH] D131300: [libc] Support StringView equality tests

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Aug 5 15:06:39 PDT 2022


michaelrj created this revision.
michaelrj added a reviewer: sivachandra.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

Previously, the integer_to_string tests used EXPECT_TRUE(.equals)
which doesn't have useful error messages. Now they properly check
equality with the EXPECT_EQ macro, which allows for comparing the
strings more naturally.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131300

Files:
  libc/test/src/__support/integer_to_string_test.cpp
  libc/utils/UnitTest/LibcTest.cpp
  libc/utils/UnitTest/LibcTest.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131300.450427.patch
Type: text/x-patch
Size: 23376 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220805/48c7f50a/attachment-0001.bin>


More information about the libc-commits mailing list