[libc-commits] [PATCH] D124204: [libc] Support 32-bit ARM platform tests

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/test/src/__support/str_to_float_test.cpp:300
 
+#ifdef __SIZEOF_INT128__
 TEST_F(LlvmLibcStrToFloatTest, EiselLemireFloat80Fallback) {
----------------
these also should be handled by the `LONG_DOUBLE_IS_DOUBLE` condition


================
Comment at: libc/test/src/stdlib/strtold_test.cpp:18
 
+#ifdef __SIZEOF_INT128__
 class LlvmLibcStrToLDTest : public __llvm_libc::testing::Test {
----------------
ddcc wrote:
> michaelrj wrote:
> > for these tests I would recommend disabling `strtold` as an entrypoint instead of putting the whole test file in an `#ifdef`. If you want, you can add a TODO for me to look into changing this test to not use uint128 when it doesn't need it.
> Are you referring to libc/config/darwin/arm/entrypoints.txt? Or omitting strtold_tests from libc/test/src/stdlib/CMakeLists.txt for arm?
actually, I think this is fine for now. I'll look into cleaning it up when I get the chance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124204/new/

https://reviews.llvm.org/D124204