[libc-commits] [PATCH] D124204: [libc] Support 32-bit ARM platform tests

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

I've added a few comments, and I've also started a thread on the LLVM discourse page for discussing plans for building LLVM-libc on arm32: https://discourse.llvm.org/t/building-llvm-libc-for-arm32/62092 <https://discourse.llvm.org/t/building-llvm-libc-for-arm32/62092> if you want to join.



================
Comment at: libc/test/src/__support/str_to_float_test.cpp:275
 
+#ifdef __SIZEOF_INT128__
 TEST_F(LlvmLibcStrToFloatTest, EiselLemireFloat80LongerMantissa) {
----------------
these shouldn't be necessary, since arm32 uses long doubles as doubles, which is caught by the condition above.


================
Comment at: libc/test/src/stdlib/strtold_test.cpp:18
 
+#ifdef __SIZEOF_INT128__
 class LlvmLibcStrToLDTest : public __llvm_libc::testing::Test {
----------------
for these tests I would recommend disabling `strtold` as an entrypoint instead of putting the whole test file in an `#ifdef`. If you want, you can add a TODO for me to look into changing this test to not use uint128 when it doesn't need it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124204/new/

https://reviews.llvm.org/D124204