[libc-commits] [libc] de94cf5 - [libc] Minor test signedness fixes

[Dominic Chen via libc-commits]

Author: Dominic Chen
Date: 2022-04-26T17:10:33-07:00
New Revision: de94cf528627f400b580a0948c8341494baf690d

URL: https://github.com/llvm/llvm-project/commit/de94cf528627f400b580a0948c8341494baf690d
DIFF: https://github.com/llvm/llvm-project/commit/de94cf528627f400b580a0948c8341494baf690d.diff

LOG: [libc] Minor test signedness fixes

Resolve compiler warnings about signed conversion

Differential Revision: https://reviews.llvm.org/D124468

Added: 
    

Modified: 
    libc/test/src/threads/cnd_test.cpp
    libc/utils/testutils/ExecuteFunction.h

Removed: 
    


################################################################################
diff  --git a/libc/test/src/threads/cnd_test.cpp b/libc/test/src/threads/cnd_test.cpp
index 960c0c1a389e8..5d69142312bdc 100644
--- a/libc/test/src/threads/cnd_test.cpp
+++ b/libc/test/src/threads/cnd_test.cpp
@@ -41,7 +41,7 @@ static mtx_t broadcast_mtx, threads_ready_mtx;
 
 int broadcast_thread_func(void *) {
   __llvm_libc::mtx_lock(&broadcast_mtx);
-  int oldval = broadcast_count.fetch_add(1);
+  unsigned oldval = broadcast_count.fetch_add(1);
   if (oldval == THRD_COUNT - 1) {
     __llvm_libc::mtx_lock(&threads_ready_mtx);
     __llvm_libc::cnd_signal(&threads_ready_cnd);

diff  --git a/libc/utils/testutils/ExecuteFunction.h b/libc/utils/testutils/ExecuteFunction.h
index c120f1f50b8eb..a4929a6ab04d9 100644
--- a/libc/utils/testutils/ExecuteFunction.h
+++ b/libc/utils/testutils/ExecuteFunction.h
@@ -24,7 +24,7 @@ struct ProcessStatus {
   int platform_defined;
   const char *failure = nullptr;
 
-  static constexpr uintptr_t TIMEOUT = -1L;
+  static constexpr unsigned TIMEOUT = ~0U;
 
   static ProcessStatus error(const char *error) { return {0, error}; }
   static ProcessStatus timed_out_ps() {
@@ -41,7 +41,7 @@ struct ProcessStatus {
 };
 
 ProcessStatus invoke_in_subprocess(FunctionCaller *func,
-                                   unsigned timeout_ms = -1);
+                                   unsigned timeout_ms = TIMEOUT);
 
 const char *signal_as_string(int signum);