[libc-commits] [PATCH] D124421: [libc] add printf writer

[Tue Ly via Phabricator via libc-commits]

lntue accepted this revision.
lntue added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/stdio/printf_core/writer.cpp:22
+    raw_write(output, new_string, length);
+  else if (chars_written + length >= max_length && chars_written < max_length)
+    raw_write(output, new_string, max_length - chars_written);
----------------
the check `chars_written + length >= max_length` is redundant.  You can move it to an inline comment as reminding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124421/new/

https://reviews.llvm.org/D124421