[libc-commits] [PATCH] D124468: [libc] Minor test signedness fixes
Alex Brachet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue Apr 26 10:41:14 PDT 2022
abrachet accepted this revision.
abrachet added inline comments.
This revision is now accepted and ready to land.
Comment at: libc/utils/testutils/ExecuteFunction.h:27
- static constexpr uintptr_t TIMEOUT = -1L;
+ static constexpr uintptr_t TIMEOUT = ~0UL;
I don't know why I ever made that uinptr that doesn't really make sense. Would you mind changing it while you're here?
Comment at: libc/utils/testutils/ExecuteFunction.h:44
ProcessStatus invoke_in_subprocess(FunctionCaller *func,
- unsigned timeout_ms = -1);
+ unsigned timeout_ms = ~0U);
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits