[libc-commits] [libc] ef6614e - [libc] Fix PrintfMatcher Cmake Rule

Michael Jones via libc-commits libc-commits at lists.llvm.org
Fri Apr 22 14:40:26 PDT 2022


Author: Michael Jones
Date: 2022-04-22T14:40:21-07:00
New Revision: ef6614e4a231f1477405949e0f4d01c3feb191ce

URL: https://github.com/llvm/llvm-project/commit/ef6614e4a231f1477405949e0f4d01c3feb191ce
DIFF: https://github.com/llvm/llvm-project/commit/ef6614e4a231f1477405949e0f4d01c3feb191ce.diff

LOG: [libc] Fix PrintfMatcher Cmake Rule

The PrintfMatcher depends on printf which is in stdio. Stdio is
currently fullbuild only, but the matcher wasn't, causing failing builds
when fullbuild was off. This patch adds the fullbuild condition to the
PrintfMatcher cmake.

Differential Revision: https://reviews.llvm.org/D124304

Added: 
    

Modified: 
    libc/utils/UnitTest/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/utils/UnitTest/CMakeLists.txt b/libc/utils/UnitTest/CMakeLists.txt
index 88d6ab84d7f55..622dbb426c5ca 100644
--- a/libc/utils/UnitTest/CMakeLists.txt
+++ b/libc/utils/UnitTest/CMakeLists.txt
@@ -54,6 +54,13 @@ add_dependencies(
   libc.src.__support.CPP.array_ref
 )
 
+if(NOT LLVM_LIBC_FULL_BUILD) # TODO(michaelrj): make a more permanant solution.
+  return()
+endif()
+
+#currently stdio is fullbuild only, so this matcher that depends on a piece of
+#printf also has to be fullbuild only.
+
 add_library(
   LibcPrintfHelpers
     PrintfMatcher.h


        


More information about the libc-commits mailing list