[libc-commits] [PATCH] D124304: [libc] Fix PrintfMatcher Cmake Rule

[Michael Jones via Phabricator via libc-commits]

michaelrj created this revision.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

The PrintfMatcher depends on printf which is in stdio. Stdio is
currently fullbuild only, but the matcher wasn't, causing failing builds
when fullbuild was off. This patch adds the fullbuild condition to the
PrintfMatcher cmake.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124304

Files:
  libc/utils/UnitTest/CMakeLists.txt


Index: libc/utils/UnitTest/CMakeLists.txt
===================================================================
--- libc/utils/UnitTest/CMakeLists.txt
+++ libc/utils/UnitTest/CMakeLists.txt
@@ -54,6 +54,13 @@
   libc.src.__support.CPP.array_ref
 )
 
+if(NOT LLVM_LIBC_FULL_BUILD) # TODO(michaelrj): make a more permanant solution.
+  return()
+endif()
+
+#currently stdio is fullbuild only, so this matcher that depends on a piece of
+#printf also has to be fullbuild only.
+
 add_library(
   LibcPrintfHelpers
     PrintfMatcher.h


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124304.424617.patch
Type: text/x-patch
Size: 530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220422/2188bc7d/attachment-0001.bin>