[libc-commits] [PATCH] D124214: [libc][NOT FOR COMMIT] building LLVM-libc on 32 bit arm with gcc

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCCheckCpuFeatures.cmake:10
   set(ALL_CPU_FEATURES SSE2 SSE4_2 AVX2 AVX512F)
-  set(LIBC_COMPILE_OPTIONS_NATIVE -march=native)
+  # set(LIBC_COMPILE_OPTIONS_NATIVE -march=native)
 elseif(${LIBC_TARGET_ARCHITECTURE_IS_AARCH64})
----------------
gchatelet wrote:
> Which gcc version is this?
`arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10-2020-q4-major) 10.2.1 20201103 (release)`


================
Comment at: libc/test/src/string/CMakeLists.txt:272
 
-add_libc_multi_impl_test(bcmp SRCS bcmp_test.cpp)
-add_libc_multi_impl_test(bzero SRCS bzero_test.cpp)
-add_libc_multi_impl_test(memcmp SRCS memcmp_test.cpp)
-add_libc_multi_impl_test(memcpy SRCS memcpy_test.cpp)
-add_libc_multi_impl_test(memmove SRCS memmove_test.cpp)
-add_libc_multi_impl_test(memset SRCS memset_test.cpp)
+# add_libc_multi_impl_test(bcmp SRCS bcmp_test.cpp)
+# add_libc_multi_impl_test(bzero SRCS bzero_test.cpp)
----------------
gchatelet wrote:
> Could you copy/paste the error message?
These were commented out from when I had the memory functions removed from the entrypoints list. The error was:

```
CMake Error at ~/llvm-project/libc/test/src/string/CMakeLists.txt:265 (target_link_libraries):
  Cannot specify link libraries for target
  "libc.test.src.string.libc.src.string.bcmp_opt_host_test" which is not
  built by this project.
Call Stack (most recent call first):
  ~/llvm-project/libc/test/src/string/CMakeLists.txt:272 (add_libc_multi_impl_test)
```

I've uncommented these lines since the memory functions are building now that there's a definition for CACHELINE_SIZE.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124214/new/

https://reviews.llvm.org/D124214