[libc-commits] [PATCH] D124130: [libc] Add Printf FormatSection Matcher

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/stdio/printf_core/core_structs.h:55
+  // optimized out for release builds.
+  bool operator==(FormatSection other) {
+    if (has_conv != other.has_conv)
----------------
FormatSection is quite big, you should use const-ref:
```
bool operator==(const FormatSection &other) const { ... }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124130/new/

https://reviews.llvm.org/D124130