[libc-commits] [PATCH] D123645: [libc][docs] Add doc for libc string functions

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/docs/strings.rst:44
+=============  ========  ===========
+Function_Name  Designed  Implemented
+=============  ========  ===========
----------------
gchatelet wrote:
> In this document, the `Designed` and `Implemented` columns are always equal. Maybe there is more value in telling which architectures are actually implemented ?
> 
Most of these string functions are completely platform independent, since they work on individual bytes at a time, so giving all of them architecture specific statuses feels redundant. On the other hand, the memory functions and the conversion functions do have possible platform differences, so tracking them could be helpful. I think the biggest problem is that all of these functions already have versions for all of our supported platforms, so no matter how we slice it the table will just say "Done" everywhere, except for the functions that we haven't started.


================
Comment at: libc/docs/strings.rst:103
+
+String Conversion Functions
+============================
----------------
gchatelet wrote:
> Maybe this should go into an `Additional Functions` section?
I like them here because it puts them before the functions that aren't implemented yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123645/new/

https://reviews.llvm.org/D123645