[libc-commits] [PATCH] D123645: [libc][docs] Add doc for libc string functions

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/docs/strings.rst:34-40
+EXEgesis Raw Memory Functions
+=============================
+
+These functions were developed by the EXEgesis team and have been
+open sourced via LLVM libc.
+
+.. TODO(gchatelet): add details about the exegesis memory functions.
----------------
Outside of Google `EXEgesis` mostly refers to `llvm-exegesis`. It is not really connected to string functions (even though it's been developed by the same people).
Maybe call the section `Primary memory function` without description and leave the TODO assigned to me (omitting the exegesis word).


================
Comment at: libc/docs/strings.rst:44
+=============  ========  ===========
+Function_Name  Designed  Implemented
+=============  ========  ===========
----------------
In this document, the `Designed` and `Implemented` columns are always equal. Maybe there is more value in telling which architectures are actually implemented ?



================
Comment at: libc/docs/strings.rst:103
+
+String Conversion Functions
+============================
----------------
Maybe this should go into an `Additional Functions` section?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123645/new/

https://reviews.llvm.org/D123645