[libc-commits] [PATCH] D123061: [libc] Add holder class for va_lists

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Apr 5 10:00:40 PDT 2022


lntue accepted this revision.
lntue added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/__support/vlist_holder.h:17
+
+class VListHolder {
+  va_list vlist;
----------------
Maybe VaListHolder is a bit clearer?


================
Comment at: libc/test/src/__support/vlist_holder_test.cpp:1
+//===-- Unittests for str_to_float ----------------------------------------===//
+//
----------------
Need to be updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123061/new/

https://reviews.llvm.org/D123061



More information about the libc-commits mailing list