[libc-commits] [PATCH] D110643: [libc] Add support for 128 bit ints in limits.h

[Alex Brachet via Phabricator via libc-commits]

abrachet added inline comments.


================
Comment at: libc/utils/CPP/Limits.h:55
 };
+template <> class NumericLimits<__uint128_t> {
+public:
----------------
michaelrj wrote:
> sivachandra wrote:
> > For completeness, should we add the limits of the signed `__int128_t` type?
> That would be non-trivial since the test framework doesn't support `__int128_t` right now.
Just need to add a new Test::test instantiation for `__int128_t` like in [[ https://github.com/llvm/llvm-project/blob/c3717b6858d32d64514a187ede1a77be8ba4e542/libc/utils/UnitTest/LibcTest.cpp#L245 | LibcTest.cpp:245 ]]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110643/new/

https://reviews.llvm.org/D110643