[libc-commits] [PATCH] D110581: [libc][NFC] Make strchr and strrchr more consistent

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/string/strrchr.cpp:16
 LLVM_LIBC_FUNCTION(char *, strrchr, (const char *src, int c)) {
-  const char ch = c;
+  const unsigned char ch = c;
   char *last_occurrence = nullptr;
----------------
Same here - keep this `char` instead of `unsigned char`. If it is `unsigned char`, then you end up comparing singed and unsigned values on line 19.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110581/new/

https://reviews.llvm.org/D110581