[libc-commits] [PATCH] D110382: [libc] Add an implementation of qsort.

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Sep 24 10:11:27 PDT 2021


michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM, approved with nit



================
Comment at: libc/src/stdlib/qsort.cpp:18
+
+class Array {
+  typedef int (*comparator)(const void *, const void *);
----------------
I think you should put this class as well as the internal quicksort function in the `internal` namespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110382/new/

https://reviews.llvm.org/D110382



More information about the libc-commits mailing list