[libc-commits] [PATCH] D109952: [libc] Add implementations of div, ldiv, lldiv and imaxdiv.

[Michael Jones via Phabricator via libc-commits]

michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: libc/config/linux/aarch64/entrypoints.txt:171-175
 if(LLVM_LIBC_FULL_BUILD)
   list(APPEND TARGET_LIBC_ENTRYPOINTS
     # stdlib.h entrypoints
-    libc.src.stdlib.abs
-    libc.src.stdlib.labs
-    libc.src.stdlib.llabs
   )
 endif()
----------------
this seems to be empty, so probably remove it, or at least the `stdlib.h` comment.


================
Comment at: libc/src/inttypes/imaxdiv.h:9
 
-#ifndef LLVM_LIBC_SRC_STDLIB_ABS_UTILS_H
-#define LLVM_LIBC_SRC_STDLIB_ABS_UTILS_H
+#ifndef LLVM_LIBC_SRC_STDLIB_IMAXDIV_H
+#define LLVM_LIBC_SRC_STDLIB_IMAXDIV_H
----------------
should be LLVM_LIBC_SRC_INTTYPES_IMAXDIV_H


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109952/new/

https://reviews.llvm.org/D109952