[libc-commits] [PATCH] D112818: [libc] Add more robust compile time architecture detection

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

Thanks for the nice cleanup.



================
Comment at: libc/src/__support/architectures.h:37-51
+#if defined(__mips64)
+#define LLVM_LIBC_ARCH_MIPS64
+#endif
+
+#if defined(__mips__) && !defined(__mips64) // mips64 also declares __mips__
+#define LLVM_LIBC_ARCH_MIPS32
+#endif
----------------
michaelrj wrote:
> I don't think we actually support these architectures yet, do we need macros for them?
I will leave it up to @gchatelet as to what he thinks about this. My personal opinion - no harm having these macros for the sake of completeness even if unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112818/new/

https://reviews.llvm.org/D112818