[libc-commits] [PATCH] D112580: [libc] add fast path to string to float conversion

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/__support/str_to_float.h:321
+  static constexpr T maxExactInt = 0;
+};
+
----------------
sivachandra wrote:
> Is it necessary to declare the members? Can we not get by with just a class declaration like this:
> 
> ```
> template <typename T> class ClingerConsts;
> ```
That was something I added when it would've allowed types without a specific set to just skip this path. I've changed it to be what you said since as it was it would return incorrect values if someone attempted to use it with a long double.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112580/new/

https://reviews.llvm.org/D112580