[libc-commits] [PATCH] D112580: [libc] add fast path to string to float conversion

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/__support/str_to_float.h:321
+  static constexpr T maxExactInt = 0;
+};
+
----------------
Is it necessary to declare the members? Can we not get by with just a class declaration like this:

```
template <typename T> class ClingerConsts;
```


================
Comment at: libc/src/__support/str_to_float.h:427
+    }
+  }
 
----------------
Can we add specific tests for the newly added conditions? Existing tests probably cover them, but having separated tests helps in isolating and debugging in future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112580/new/

https://reviews.llvm.org/D112580