[libc-commits] [PATCH] D112104: [libc] add malloc funcs as external entrypoints

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCLibraryRules.cmake:42
+    return()
+  endif()
 endfunction(collect_object_file_deps)
----------------
sivachandra wrote:
> Wouldn't this silently ignore all external objects?
You're right it does, I'm not sure why this ever worked. It's fixed now (I checked the resulting .a file to be sure).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112104/new/

https://reviews.llvm.org/D112104