[libc-commits] [PATCH] D112104: [libc] add malloc funcs as external entrypoints

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/cmake/modules/LLVMLibCLibraryRules.cmake:42
+    return()
+  endif()
 endfunction(collect_object_file_deps)
----------------
sivachandra wrote:
> Wouldn't this silently ignore all external objects?
Add a comment here saying something like,

```
It is not possible to recursively extract deps of external dependencies.
So, we just accumulate the direct dep and return.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112104/new/

https://reviews.llvm.org/D112104