[libc-commits] [PATCH] D112104: [libc] add malloc funcs as external entrypoints

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

This is almost what I had in mind. It is still "almost" because of a question I left inline.



================
Comment at: libc/cmake/modules/LLVMLibCLibraryRules.cmake:42
+    return()
+  endif()
 endfunction(collect_object_file_deps)
----------------
Wouldn't this silently ignore all external objects?


================
Comment at: libc/cmake/modules/LLVMLibCObjectRules.cmake:287
+      "OBJECT_FILE" ""
+      "OBJECT_FILE_RAW" ""
+      "DEPS" "${ADD_ENTRYPOINT_EXT_DEPENDS}"
----------------
External entrypoints will not have an object file produced by the libc build. So, we don't need `OBJECT_FILE` and `OBJECT_FILE_RAW` properties.


================
Comment at: libc/src/stdlib/CMakeLists.txt:190
+    message(FATAL_ERROR "Architecture ${LIBC_TARGET_ARCHITECTURE} is not supported by SCUDO. 
+Either disable LLVM_LIBC_INCLUDE_SCUDO or change your target architecture.")
+  endif()
----------------
Indent this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112104/new/

https://reviews.llvm.org/D112104