[libc-commits] [PATCH] D112176: [libc] fix strtol returning the wrong length

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/__support/str_conv_utils.h:65
   unsigned long long result = 0;
+  bool seen_digit = false;
+  const char *original_src = src;
----------------
Nit: s/`seen_digit`/`is_number`?


================
Comment at: libc/src/__support/str_conv_utils.h:83
+    seen_digit = true;
+  }
+
----------------
Do we need this `if` block at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112176/new/

https://reviews.llvm.org/D112176