[libc-commits] [PATCH] D111624: [libc] automemcpy - result analyzer

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

Will update the patch with more comments shortly.



================
Comment at: libc/benchmarks/automemcpy/lib/ResultAnalyzer.cpp:160-162
+  StringMap<double> Throughputs; // Median of samples per distribution
+  StringMap<double> Scores;      // Normalized score per distribution
+  StringMap<Grade::GradeEnum> GradeAttribution; // Grade per distribution
----------------
courbet wrote:
> any reason not to group `{Throughput,Score,GradeAttribution}` to avoid the 3 parallel maps ?
Yes, `Throughputs` is currently move constructed (see line 185).
I can extract the distribution data into its own data structure with 3 fields, but then I'll have to iterate the map to construct `Throughputs` instead of moving it.
I'll update the patch with the new version so you can judge.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111624/new/

https://reviews.llvm.org/D111624