[libc-commits] [PATCH] D111621: [libc] automemcpy - function generator
Clement Courbet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue Oct 19 00:16:07 PDT 2021
courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: libc/benchmarks/automemcpy/lib/RandomFunctionGenerator.cpp:23
+// Here we define a set of values that will contraint the exploration and
+// prevent combinatorial explosion.
+
----------------
[nit] maybe "limit" more than "prevent", this is still combinatorial :)
================
Comment at: libc/benchmarks/automemcpy/lib/RandomFunctionGenerator.cpp:57
+
+// For memcpy, we can also explore the whether aligning on source or destination
+// has an effect.
----------------
extra "the"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111621/new/
https://reviews.llvm.org/D111621
More information about the libc-commits
mailing list