[libc-commits] [PATCH] D111583: [libc] Add strncat and fix strcat

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Oct 17 22:23:54 PDT 2021


sivachandra added inline comments.


================
Comment at: libc/src/string/strcat.cpp:22
+  __llvm_libc::strcpy(dest + destLength, src);
+  dest[destLength + srcLength] = '\0';
   return dest;
----------------
Its not clear to me as to what this change has done that something got "fixed". A corresponding test would have helped me see it may be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111583/new/

https://reviews.llvm.org/D111583



More information about the libc-commits mailing list