[libc-commits] [PATCH] D111622: [libc] automemcpy - codegen

[Clement Courbet via Phabricator via libc-commits]

courbet added inline comments.


================
Comment at: libc/benchmarks/automemcpy/lib/CodeGen.cpp:19
+//      llvm::ArrayRef<MemcmpConfiguration> getMemcmpConfigurations();
+//      llvm::ArrayRef<MemcmpConfiguration> getBcmpConfigurations();
+//      llvm::ArrayRef<MemsetConfiguration> getMemsetConfigurations();
----------------
typo


================
Comment at: libc/benchmarks/automemcpy/lib/CodeGen.cpp:36
+// Note the code here is better understood by starting from the `Main` function
+// at the end of the file.
+
----------------
which `Main` ?


================
Comment at: libc/benchmarks/automemcpy/lib/CodeGen.cpp:51
+// The indentation string.
+static constexpr StringRef kIndent = "  ";
+
----------------
move inside `codegen` ?


================
Comment at: libc/benchmarks/automemcpy/lib/CodeGen.cpp:546
+                      ArrayRef<NamedFunctionDescriptor> Descriptors) {
+  Stream << "// Functions : " << Descriptors.size() << "\n";
+  Stream << "\n";
----------------
Add the usual warning about the file being autogenerated ?


================
Comment at: libc/benchmarks/automemcpy/lib/CodeGenMain.cpp:14
+    FunctionDescriptor FD = *MaybeFD;
+    if (Seen.count(FD)) // The solver sometimes return twice the same object.
+      continue;
----------------
This should be a FIXME.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111622/new/

https://reviews.llvm.org/D111622