[libc-commits] [PATCH] D102233: [libc] Simplifies multi implementations and benchmarks

Thu Oct 7 08:17:24 PDT 2021

gchatelet added a comment.

In D102233#3048055 <https://reviews.llvm.org/D102233#3048055>, @gchatelet wrote:

> In D102233#3048033 <https://reviews.llvm.org/D102233#3048033>, @Abpostelnicu wrote:
>
>> In D102233#3048032 <https://reviews.llvm.org/D102233#3048032>, @gchatelet wrote:
>>
>>> In D102233#3047627 <https://reviews.llvm.org/D102233#3047627>, @Abpostelnicu wrote:
>>>
>>>> Using clang-13, that has this changeset I encounter: clang-13: error: the clang compiler does not support '-march=native'.
>>>
>>> Thx for reporting @Abpostelnicu . Which CPU are you compiling for?
>>
>> thanks for the reply, aarch64. You can see the build <https://firefox-ci-tc.services.mozilla.com/tasks/EbKlo8qXQZaEJPR4eTeW6A/runs/0/logs/public/logs/live.log#L12979>.
>
> I see thx.
> The issue comes from the cross compilation.
> We should disable host optimized targets when cross compiling as it pulls in invalid compilation flags.
> I'll prepare a patch.

Actually, AFAIU it's an issue with the toolchain configuration.
CMake specifies <https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_PROCESSOR.html>: //When cross-compiling, a CMAKE_TOOLCHAIN_FILE should set the CMAKE_SYSTEM_PROCESSOR variable to match target architecture that it specifies (via CMAKE_<LANG>_COMPILER and perhaps CMAKE_<LANG>_COMPILER_TARGET).//
When I look at the CMake cmd line <https://firefox-ci-tc.services.mozilla.com/tasks/EbKlo8qXQZaEJPR4eTeW6A/runs/0/logs/public/logs/live.log#L13025> I don't see a `-DCMAKE_SYSTEM_PROCESSOR=aarch64-linux-android`.
Can you have a look?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102233/new/

https://reviews.llvm.org/D102233